Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix send transactions sometimes showing balance undefined and infinite loaders with ERC20 tokens #1846

Merged
merged 3 commits into from
Sep 28, 2020

Conversation

EtDu
Copy link
Contributor

@EtDu EtDu commented Sep 23, 2020

@EtDu EtDu requested a review from a team as a code owner September 23, 2020 06:19
@EtDu EtDu added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 23, 2020
@EtDu
Copy link
Contributor Author

EtDu commented Sep 23, 2020

@ibrahimtaveras00 To reproduce consistently for QA:

  1. Scan a receive QR code
  2. Click edit in top left corner
  3. Change asset to an ERC-20 token
  4. Change the amount and press Next

@rdymac
Copy link

rdymac commented Sep 23, 2020

Other cases that might be affected by this issue: 53379, 51793

@EtDu EtDu added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 24, 2020
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for the steps to reproduce how @EtDu described 👍

However, I don't think this fix will work for the other issue @rdymac described = 53150 as I couldn't withdraw from our test-dapp
seen here = https://recordit.co/kpV304DD5Y

Screen Shot 2020-09-25 at 5 47 18 PM

But I believe that is out of the scope of what this PR actually fixes so I will at least pass this PR

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done next release and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Sep 25, 2020
@estebanmino estebanmino merged commit a71cc4a into develop Sep 28, 2020
@estebanmino estebanmino deleted the send-tx-bug branch September 28, 2020 18:24
@EtDu
Copy link
Contributor Author

EtDu commented Sep 29, 2020

@ibrahimtaveras00 The problem you found here isn't only with mobile, it occurs on the extension as well. It's a bug having to do with the way gas estimation works. I do feel we could do better at displaying the error message to the user instead of doing nothing though

@omnat
Copy link
Contributor

omnat commented Oct 8, 2020

New support issue came up 57946 on Oct 6 (trying to send sxp), looks like this is still happening.
@EtDu @ibrahimtaveras00

@EtDu
Copy link
Contributor Author

EtDu commented Oct 10, 2020

#1889 updated fix!

rickycodes pushed a commit that referenced this pull request Jan 31, 2022
…h ERC20 tokens (#1846)

Co-authored-by: Esteban Miño <efmino@uc.cl>
salimtb added a commit that referenced this pull request Mar 19, 2024
## **Description**

The primary currency toggle provides unnecessary overhead for every
asset feature we build. The Extension team is removing it for Extension
and we will do so as well for Mobile.
the default one on mobile will be Native.


## **Related issues**

Fixes:
[#1846](MetaMask/MetaMask-planning#1846 (comment))

## **Manual testing steps**

1. Go the setting page
2. Go to general
3. Primary currency toggle is removed, the default one is Native

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->
<img width="478" alt="Screenshot 2024-02-24 at 15 53 46"
src="https://github.com/MetaMask/metamask-mobile/assets/26223211/e45108fe-884a-4fcd-8fdb-3788e7448884">

### **After**

<!-- [screenshots/recordings] -->
<img width="499" alt="Screenshot 2024-02-24 at 15 42 12"
src="https://github.com/MetaMask/metamask-mobile/assets/26223211/adb343d1-114b-4bdf-b6c0-444f5832e62f">

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [x] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants